Mihaela Mihaljevic
57c0c3b2da
Slice 2 of #94. One call for an editor: PureXML.lint reads the document once into the ranged, best-effort tree (never throwing), then merges the parse diagnostics and the validation findings into a single source-ranged, severity-tagged list in document order. - LintDiagnostic carries message, severity, and the SourceRange to highlight. - lint(_:validate:) takes a node-based validate closure that runs over the RECOVERED tree, so validation works even when the document is not well-formed: a truncated, schema-invalid document yields both a parse diagnostic and the validation finding, each with a range. - Schema.Document gains validate(_ node:) so a caller validates the same tree it is editing; validate(_ xml:) delegates to it. Tests cover a clean lint, well-formedness-only lint, a range-located validation finding, and the both-truncated-and-invalid editor case.
64 lines
2.6 KiB
Swift
64 lines
2.6 KiB
Swift
@testable import PureXML
|
|
import Testing
|
|
|
|
/// The unified lint surface: one source-ranged, severity-tagged list merging
|
|
/// parse recovery and schema validation, the way an editor consumes it.
|
|
@Suite("Lint")
|
|
struct LintTests {
|
|
@Test("A well-formed, valid document lints clean")
|
|
func test_clean() throws {
|
|
let xsd = """
|
|
<xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema">
|
|
<xs:element name="n" type="xs:integer"/>
|
|
</xs:schema>
|
|
"""
|
|
let schema = try PureXML.Schema.Document(xsd)
|
|
#expect(PureXML.lint("<n>3</n>", validate: schema.validate).isEmpty)
|
|
}
|
|
|
|
@Test("Well-formedness alone is linted without a schema")
|
|
func test_parseOnly() {
|
|
let diagnostics = PureXML.lint("<a><b>x")
|
|
#expect(diagnostics.count == 1)
|
|
#expect(diagnostics[0].message.contains("unexpected end of input"))
|
|
#expect(diagnostics[0].range != nil)
|
|
}
|
|
|
|
@Test("A validation finding is located by source range")
|
|
func test_validationRanged() throws {
|
|
let xsd = """
|
|
<xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema">
|
|
<xs:element name="order">
|
|
<xs:complexType>
|
|
<xs:sequence><xs:element name="qty" type="xs:integer"/></xs:sequence>
|
|
</xs:complexType>
|
|
</xs:element>
|
|
</xs:schema>
|
|
"""
|
|
let schema = try PureXML.Schema.Document(xsd)
|
|
let diagnostics = PureXML.lint("<order>\n <qty>lots</qty>\n</order>", validate: schema.validate)
|
|
#expect(diagnostics.count == 1)
|
|
#expect(diagnostics[0].severity == .error)
|
|
#expect(diagnostics[0].range?.start == PureXML.Parsing.Mark(line: 2, column: 3, offset: 10))
|
|
}
|
|
|
|
@Test("Validation runs over the recovered tree, so invalid input still lints")
|
|
func test_invalidStillValidates() throws {
|
|
// The document is both not well-formed (truncated) and schema-invalid.
|
|
let xsd = """
|
|
<xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema">
|
|
<xs:element name="order">
|
|
<xs:complexType>
|
|
<xs:sequence><xs:element name="qty" type="xs:integer"/></xs:sequence>
|
|
</xs:complexType>
|
|
</xs:element>
|
|
</xs:schema>
|
|
"""
|
|
let schema = try PureXML.Schema.Document(xsd)
|
|
let diagnostics = PureXML.lint("<order><qty>lots", validate: schema.validate)
|
|
// One parse diagnostic (truncation) and one validation finding (qty not an integer).
|
|
#expect(diagnostics.contains { $0.message.contains("unexpected end of input") })
|
|
#expect(diagnostics.contains { $0.message.contains("not a valid") })
|
|
}
|
|
}
|